Signature settings in ACP are not applied

[Angelus]

Hi.
I have a problem setting up the rules for signatures in ACP.

For example one can set allow [URL] or [IMG] to YES and than send these changes. But after I return to the config page the setting is NO again. Also changes in the number of allowed images (field is empty) doesn't take any effect even if I reset the signatures and than change the settings. They seem not to be stored in DB. This does not work with integra 1.4.0 in combination with phpBB 2.0.17 and 2.0.19. I thought the settings made in the fields (eg. max number of allowed images in signature) should be displayed but as I said the fields are empty.

Has anyone any ideas about that?

Greetings
Thorsten

[Threat009]

Did you confirm the changes? Maybe a dumb question, but I think there's a confirm, or commit something or other at the bottom of the page you have to hit after you make your changes.

[Angelus]

Yes I did this and clicked after this at the link to return to the config page. Other settings for example avatar settings work without problems.

[Angelus]

Problem still not solved.

It is possible that this problem has something to wo with the update from my previous phpBB 2.0.17. I have a fresh install of 1.4.0 and in that the problem does not occur.

[kyber]

I have just upgraded from 132 to 140 and have this problem as well. I am just starting the patch upgrade process to bring everything as up-to-date as possible and am hoping this will resolve the problem although given the above posts this now seems unlikely.

Stuart

[kyber]

Looking at the 140 installation code, I find this:

Code: Select all

INSERT INTO `phpbb_config` VALUES ('sig_max_lines', '5');INSERT INTO `phpbb_config` VALUES ('sig_wordwrap', '100');INSERT INTO `phpbb_config` VALUES ('sig_allow_font_sizes', '1');INSERT INTO `phpbb_config` VALUES ('sig_min_font_size', '7');INSERT INTO `phpbb_config` VALUES ('sig_max_font_size', '12');INSERT INTO `phpbb_config` VALUES ('sig_allow_bold', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_italic', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_underline', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_colors', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_quote', '0');INSERT INTO `phpbb_config` VALUES ('sig_allow_code', '0');INSERT INTO `phpbb_config` VALUES ('sig_allow_list', '0');INSERT INTO `phpbb_config` VALUES ('sig_allow_url', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_images', '1');INSERT INTO `phpbb_config` VALUES ('sig_max_images', '0');INSERT INTO `phpbb_config` VALUES ('sig_max_img_height', '75');INSERT INTO `phpbb_config` VALUES ('sig_max_img_width', '500');INSERT INTO `phpbb_config` VALUES ('sig_allow_on_max_img_size_fail', '0');INSERT INTO `phpbb_config` VALUES ('sig_max_img_files_size', '10');INSERT INTO `phpbb_config` VALUES ('sig_max_img_av_files_size', '0');INSERT INTO `phpbb_config` VALUES ('sig_exotic_bbcodes_disallowed', '');INSERT INTO `phpbb_config` VALUES ('sig_allow_smilies', '1');

and I do not find any of those items in my current "upgraded" database.

Looking back through the various update scripts, I can not see anything that should have added those files.

Not sure if I am supposed to have run 140 install code as well as installing advised files over the top of my 132 files and running just the three db update files.

Note sure if there are other entries missing from the table. Was just looking at the signatures for now.

Perhaps I need to do a clean install somewhere and then compare the datastructures.

I am surprised though that the code did not complain about missing fields.

Stuart

[kyber]

I have run the update code for just the signature entries using phpmyadmin and all seems well.

Obviously I have missed an instruction somewhere or these lines are missing from the upgrade update db files.

Stuart

[Angelus]

Yes that solved the problem.Now the fields are filled with values that are obviously stored when changed.

Thanks!!!

[Angelus]

I have to reopen this topic. The values are now applied in the ACP. But after resetting the signatures the signatures are still not affectd by the settings.

So if I allow only 1image and reset all signatures a user can still use as much pictures as he wants to.
Also other settings like file size or general verbose of using url does not have any affect.

The only thing that takes effect is the limit of 255 letters in the signature. The limit of yy lines has also no effect.
Someone any idea how to correct that?

Greetings
Thorsten

[Angelus]

Hi I still have the problem that the ACP changes have no effect. I also now switched the Signatue Settings to "Contolled" but this has also no effect.

EDIT: I have looked to a integra 1.4.0 standard installation. The ACP settings for signatures do not work either.

Please help!!
Greetings
Thorsten

[Angelus]

Sorry for posting again but the problem is still not solved. Settings still have no effect after applying.

Greetings
Thorsten

[Master Dwarf]

I have to give this a bump.

I am disallowing images for sigs but the setting is not being applied, and they are showing up in my forums. Some (images) are getting big and starting to mess up the formatting of the forums.

Do you have to apply the changes and then do a 'Reset'? This says:

Erase the signature in the profile of all the members! This is to oblige them to set it again, and then passed the signature control

Will this fix things? I'd just hate to delete sigs only to continue for the change to not go into effect.

update: I reset (erased) all sigs using 'Reset'. It deleted all sigs. I logged in using a nonadmin account and I could still use images. So the resetting does not work.

[Teelk]

This is a known bug and is currently being looked into.

[Master Dwarf]

Good to know. Thanks Teelk!

[Angelus]

Will this be fixed in 1.40 or only in 1.41?

Greetings
Thorsten

[Pggar]

I was checking the code and there seems to be no bug. The problem lies in the fact that the code is not checking any of those limits.

Here's the code from profilcp_profil_signature.php:

Code: Select all

     if ( $signature != '' )     {         if ( strlen($signature) > $board_config['max_sig_chars'] )         {             $error = true;             $error_msg .= ( ( isset($error_msg) ) ? '<br>' ];         }         if ( !isset($signature_bbcode_uid) || $signature_bbcode_uid == '' )         {             $signature_bbcode_uid = ( $view_userdata['user_allowbbcode'] ) ? make_bbcode_uid() : '';         }         $signature = prepare_message($signature, $view_userdata['user_allowhtml'], $view_userdata['user_allowbbcode'], $view_userdata['user_allowsmile'], $signature_bbcode_uid);           $view_userdata['user_sig'] = $signature;         $view_userdata['user_sig_bbcode_uid'] = $signature_bbcode_uid;     }  

If I understood that correctly, it is only checking the "max_sig_chars". At least that's the only time it sets an error message. The funcion prepare_message only checks if HTML is enabled or not.


After that we have the following code:

Code: Select all

     if ( $error )     {         message_die(GENERAL_ERROR, $error_msg);     }     if (!$error && !$preview)     {         $sql = "UPDATE " . USERS_TABLE . "                 SET                     user_sig = '" . $signature . "',                     user_sig_bbcode_uid = '" . $signature_bbcode_uid . "'                 WHERE                     user_id = " . $view_userdata['user_id'];         if ( !$result = $db->sql_query($sql) )         {             message_die(GENERAL_ERROR, 'Could not update user table', '', __LINE__, __FILE__, $sql);         }     }  

If there was no error with the "max_sig_chars" checking and you're not trying to preview your sig, the board procedes to save the signature to your database.

If I had a bit more knowledge of php I would procede and mod that file so it checks everything it was supposed to check. Since I do not have it, I'll wait for you guys to do it. Meanwhile, I'll check if that code is not lost somewhere else in the code, cause I remenber that when the signature didn't have a separate page the limits worked fine.


Edit 1]Edit 2[/color]: I analysed the mod code. There is a lot of code that was not added to IM. The only part that seems to have been added was the editing of values on the ACP. All the code for checking the values was not included. I'll do some tests with the code once I finish some other adjustments on my board. I'll let you know what happens.

[Angelus]

Thanks Pggar. But it is really surprising, that the interest of this topic is so small. I think the signature settings are rather important.

I'm very interested in fixing this problem

Greetings
Thorsten

[Pggar]

It looks like all we have to do is complete the mod installation.
However, we should install it on profilcp_profil_signature.php.

I didn't have the time to analyse the code from that file to see if it is very different from the original signature code. I believe they are quite similar. In that case, the mod installation should be straightforward.

The bad news is, if you're counting on me, I should be able to check the mod only next week. So, you'll have to wait a bit.

[Angelus]

Ok thanks I have time. This problem lasts long time yet <img>

Just let me/us know if you solved the problem.

Greetings
Thorsten

[Teelk]

This has been fixed in the latest beta revision. I'll backport the changes for you when I get the chance. If I don't post the fix within the next couple of days, feel free to bump this post so I don't forget.

[Angelus]

Great thank you!!!

Greetings
Thorsten

[Angelus]

@ Teelk: What's about the changes to fix that problem?

Greetings
Thorsten

[lordtopcat]

I don't know if this applies too, but my Signature settings stay the same, but don't take effect.

I have a maximum of 3 signautre lines set in the config, and yet I can create more lines than that.

[Master Dwarf]

I don't know if this applies too, but my Signature settings stay the same, but don't take effect.

I have a maximum of 3 signautre lines set in the config, and yet I can create more lines than that.

I have run into restrictions on the signature length limit, but I wouldn't doubt that something is amuck.

[IntegraMOD]

I am not sure but I think that changing sig settings will not change current signatures but just enforce anything new.

[Angelus]

That's correct. If you change the settings and want to apply them to all users you have to RESET the signatures.

Greetings
Thorsten

[Teelk]

Sorry everyone, I was without an internet connection for a while. But, I'm back now and I'll try and have these changes as soon as possible. May take me some time though, since it's been a few weeks since I made the changes to the beta, I've kinda forgotten what those changes were. I can look them up though...

[Helter]

you are correct that these qurries were missed by the phpbb_to_140_update

Code: Select all

INSERT INTO `phpbb_config` VALUES ('sig_max_lines', '5');INSERT INTO `phpbb_config` VALUES ('sig_wordwrap', '100');INSERT INTO `phpbb_config` VALUES ('sig_allow_font_sizes', '1');INSERT INTO `phpbb_config` VALUES ('sig_min_font_size', '7');INSERT INTO `phpbb_config` VALUES ('sig_max_font_size', '12');INSERT INTO `phpbb_config` VALUES ('sig_allow_bold', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_italic', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_underline', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_colors', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_quote', '0');INSERT INTO `phpbb_config` VALUES ('sig_allow_code', '0');INSERT INTO `phpbb_config` VALUES ('sig_allow_list', '0');INSERT INTO `phpbb_config` VALUES ('sig_allow_url', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_images', '1');INSERT INTO `phpbb_config` VALUES ('sig_max_images', '0');INSERT INTO `phpbb_config` VALUES ('sig_max_img_height', '75');INSERT INTO `phpbb_config` VALUES ('sig_max_img_width', '500');INSERT INTO `phpbb_config` VALUES ('sig_allow_on_max_img_size_fail', '0');INSERT INTO `phpbb_config` VALUES ('sig_max_img_files_size', '10');INSERT INTO `phpbb_config` VALUES ('sig_max_img_av_files_size', '0');INSERT INTO `phpbb_config` VALUES ('sig_exotic_bbcodes_disallowed', '');INSERT INTO `phpbb_config` VALUES ('sig_allow_smilies', '1');

you can run these through phpmyadmin for now.

[Merrillizer]

I did those insertions, but still no sig. The settings are now taking in the ACP, but still nothing on the board.

[Whisky]

Just find this thread now, applied the fix and that solved my problem.

I am unconsciously replying to pull the subject out of infinite spirals of forgotten to be sure the fix will be applied for 1.4.1 <img>

[Teelk]

Fixed many moons ago...

[viragotech]

HELP I NEED THIS

#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '('sig_max_lines', '5'); INSERT INTO `phpbb_config` VALUES ('sig_wor' at line 1

you are correct that these qurries were missed by the phpbb_to_140_update

Code: Select all

INSERT INTO `phpbb_config` VALUES ('sig_max_lines', '5');INSERT INTO `phpbb_config` VALUES ('sig_wordwrap', '100');INSERT INTO `phpbb_config` VALUES ('sig_allow_font_sizes', '1');INSERT INTO `phpbb_config` VALUES ('sig_min_font_size', '7');INSERT INTO `phpbb_config` VALUES ('sig_max_font_size', '12');INSERT INTO `phpbb_config` VALUES ('sig_allow_bold', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_italic', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_underline', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_colors', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_quote', '0');INSERT INTO `phpbb_config` VALUES ('sig_allow_code', '0');INSERT INTO `phpbb_config` VALUES ('sig_allow_list', '0');INSERT INTO `phpbb_config` VALUES ('sig_allow_url', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_images', '1');INSERT INTO `phpbb_config` VALUES ('sig_max_images', '0');INSERT INTO `phpbb_config` VALUES ('sig_max_img_height', '75');INSERT INTO `phpbb_config` VALUES ('sig_max_img_width', '500');INSERT INTO `phpbb_config` VALUES ('sig_allow_on_max_img_size_fail', '0');INSERT INTO `phpbb_config` VALUES ('sig_max_img_files_size', '10');INSERT INTO `phpbb_config` VALUES ('sig_max_img_av_files_size', '0');INSERT INTO `phpbb_config` VALUES ('sig_exotic_bbcodes_disallowed', '');INSERT INTO `phpbb_config` VALUES ('sig_allow_smilies', '1');

you can run these through phpmyadmin for now.

[Helter]

the quoted text should look like this

you are correct that these qurries were missed by the phpbb_to_140_update

Code: Select all

INSERT INTO `phpbb_config` VALUES ('sig_max_lines', '5');INSERT INTO `phpbb_config` VALUES ('sig_wordwrap', '100');INSERT INTO `phpbb_config` VALUES ('sig_allow_font_sizes', '1');INSERT INTO `phpbb_config` VALUES ('sig_min_font_size', '7');INSERT INTO `phpbb_config` VALUES ('sig_max_font_size', '12');INSERT INTO `phpbb_config` VALUES ('sig_allow_bold', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_italic', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_underline', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_colors', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_quote', '0');INSERT INTO `phpbb_config` VALUES ('sig_allow_code', '0');INSERT INTO `phpbb_config` VALUES ('sig_allow_list', '0');INSERT INTO `phpbb_config` VALUES ('sig_allow_url', '1');INSERT INTO `phpbb_config` VALUES ('sig_allow_images', '1');INSERT INTO `phpbb_config` VALUES ('sig_max_images', '0');INSERT INTO `phpbb_config` VALUES ('sig_max_img_height', '75');INSERT INTO `phpbb_config` VALUES ('sig_max_img_width', '500');INSERT INTO `phpbb_config` VALUES ('sig_allow_on_max_img_size_fail', '0');INSERT INTO `phpbb_config` VALUES ('sig_max_img_files_size', '10');INSERT INTO `phpbb_config` VALUES ('sig_max_img_av_files_size', '0');INSERT INTO `phpbb_config` VALUES ('sig_exotic_bbcodes_disallowed', '');INSERT INTO `phpbb_config` VALUES ('sig_allow_smilies', '1');

you can run these through phpmyadmin for now.