SQL syntax

[midjam]

Hi guys

Please could someone help me with an error i`m getting.

I have phpBB and IM Portal

Whenever i go to reply to a post and i scroll down to see what has been posted i get this error message

Could not query users

DEBUG MODE

SQL Error : 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 4

SELECT username, user_id, user_posts, user_avatar, user_avatar_type, user_allowavatar FROM phpbb_users WHERE user_id <> -1 ORDER BY user_posts DESC LIMIT

Line : 38
File : blocks_imp_top_posters.php

I can post and everything works ok, but how do i get rid of this error?

[Michaelo]

Ca you open blocks_imp_top_posters.php and post the line 38 here so I can see what it is...
It should be something like:

Code: Select all

                  WHERE user_id <> " . ANONYMOUS . "  

Mike

[midjam]

Thanks for your help

I have posted all the code

if ( !defined('IN_PHPBB') )
{
die("Hacking attempt");
}

if(!function_exists(imp_top_posters_func))
{
function imp_top_posters_func()
{
global $lang, $template, $portal_config, $board_config, $db, $phpEx;

$sql = "SELECT username, user_id, user_posts, user_avatar, user_avatar_type, user_allowavatar
FROM " . USERS_TABLE . "
WHERE user_id <ANONYMOUS>sql_query($sql)) )
{
message_die(GENERAL_ERROR, 'Could not query users', '', __LINE__, __FILE__, $sql);
}

if ( $row = $db->sql_fetchrow($result) )
{
$i = 0;
do
{
$username = $row['username'];
$user_id = $row['user_id'];
$posts = ( $row['user_posts'] ) ? $row['user_posts'] : 0;
$poster_avatar = '';
if ( $row['user_avatar_type'] && $user_id != ANONYMOUS && $row['user_allowavatar'] )
{
switch( $row['user_avatar_type'] )
{
case USER_AVATAR_UPLOAD:
$poster_avatar = ( $board_config['allow_avatar_upload'] ) ? '<img>' : '';
break;
case USER_AVATAR_REMOTE:
$poster_avatar = ( $board_config['allow_avatar_remote'] ) ? '<img>' : '';
break;
case USER_AVATAR_GALLERY:
$poster_avatar = ( $board_config['allow_avatar_local'] ) ? '<img>' : '';
break;
}
}



$template->assign_block_vars('topposter', array(
'USERNAME' => $username,
'POSTS' => $posts,
'AVATAR_IMG' => $poster_avatar,
'U_VIEWPOSTER' => append_sid("profile.$phpEx?mode=viewprofile&" . POST_USERS_URL . "=$user_id"),
'U_VIEWPOSTS' => append_sid("search.php?search_author=" . $username . "&showresults=posts")
)
);

$i++;
}
while ( $row = $db->sql_fetchrow($result) );
}

$template->assign_vars(array(
'L_POSTS' => $lang['Posts']
)
);
}
}

imp_top_posters_func();

[Michaelo]

Have you 141 or 140?
If 141 the mod has not been installed so iy can't be used. Disable the block in ACP-IM Portal...
If 140, check ACP - > IM Portal -> Portal Configuration and see if you have an entry for md_total_poster or just total_poster... if so make sure it is a positive number, say 5...

Let me know how you get on...
Mike