Advanced Group Color Management - IM 141

[nGAGE]

There seems to be a bug regarding group moderators, where they show up as "username_color" instead of with the correct group name. To view this, just assign to any group the moderation of a forum and view that forum.

After banging my head for a while (I don't know any PHP) I was able to find and fix the problem. Just go to includes/functions_categories_hierarchy.php and replace

Code: Select all

$s_group_names .= ( empty($s_group_names) ? '' : ', ' ) . sprintf("'%s'", str_replace("'", "'", $agcm_color->get_user_color($data['user_group_id'][$j], $data['group_name'][$j])));

with

Code: Select all

$s_group_names .= ( empty($s_group_names) ? '' : ', ' ) . sprintf("'%s'", str_replace("'", "'", $agcm_color->get_user_color($data['group_id'][$j], 0, $data['group_name'][$j])));

on line 425.

I hope this is useful to someone!


SÃÂÂ ©rgio Gomes

This fix worked fine for me... Thnx, but there is a nother little problem with it... don't know if it has to do with "cache" yet... will have to check that!

If you change the name of a group, for example from "Administrators" to "Admins"... it keeps displaying "Administrators"...
Like I said... have to check if it's a caching thing, but I currently solved it by going into the group/permissions for a group and without changing anything simply "Submit" again.
After that it's changed to "Admins"

[nGAGE]

OK... So I've now tried several things... Clearing Cache in IM-PORTAL of the ACP and via EXTREME-STYLES Manage Cache in ACP, and it both doesn't solve the minor issue!

Further I've tested changing group type. This issue also occurs when changing the group-type from Closed to Hidden (group remains visible on forum) and also the other way around. If from Hidden to closed, group does not become visible, until you go to Group-Permissions and submit again.
So the problem happens somewhere in that it stores and reads the data but not dynamically updates it (I guess)

Any suggestions?

[nGAGE]

Hmmm... VERY ODD!

Now I've made a post in my own BUG-TRACKER forum to not forget a bout this... and after the post it updated it
But why doesn't it do it after changes are made in ACP?

[EDIT-2]: I've now waited over 30-min and it doesn't change if I don't make a new post, after making a name change to the usergroup! So definately not a cache issue. Must be something that's missing in the admin/admin_groups.php or the admin/admin_group_extend.php that causes it to not update, I'd guess. Or... Aww shoot... dunno what files to look at, as it also update when posting :S

Perhaps in the files responsible/used when posting/editing it reads something from database that is not read after updating info on Group/Manage of ACP?

Will have a "beginer"-look at those to see if I notice anything <img>

[nGAGE]

Another Question about this MOD... When adding new usergroups, it always adds them to the top of the list in ACPs Group/Colors... That can be a pain in the "you know what" when you constantly have to move them down. I'll see if I can findout why or where to change it to display the otherway arround, but if I can't find it... any suggestions are welcome.

[nGAGE]

OK... so this has been going wrong again for me and I think the earlier mentioned fix wasn't a fix, but rather a bypass for the bug.

FILE: /includes/functions_categories_hierarchy.php

I think there is something wrong with this part:

Code: Select all

 $agcm_color->get_user_color($data['group_id'][$j], 0, $data['group_name'][$j])  

I think it should be this (and it has the same effect and works for me):

Code: Select all

 $agcm_color->get_user_color($data['group_id'][$j], $data['user_group_id'][$j], $data['group_name'][$j])  

Please correct me if I'm wrong, but the correct fix on that line of code should be this:

Code: Select all

 ##-----[ FIND ]------------------------------------------#             $s_group_names .= ( empty($s_group_names) ? '' : ', ' ) . sprintf("'%s'", str_replace("'", "'", $agcm_color->get_user_color($data['user_group_id'][$j], $data['group_name'][$j])));  ##-----[ REPLACE WITH ]------------------------------------------#             $s_group_names .= ( empty($s_group_names) ? '' : ', ' ) . sprintf("'%s'", str_replace("'", "'", $agcm_color->get_user_color($data['group_id'][$j], $data['user_group_id'][$j], $data['group_name'][$j])));        

This has the same effect and will call the correct "group_id" + "user_group_id"

Which since this afternoon on the other fix (don't know if it had to do with the value ", 0" that was there), somehow set all my users' user_group_id to "0" and no colors displayed anymore.

Somewhere there must be some code that doesn't update the phpbb_users.user_group_id properly (I think)... I'm still searching... going through the manual install for clues.

[nGAGE]

Ok... I'm still convinced my version for displaying the forum moderators is the correct one, but now also want to call off false alarm on the updating issue.
Another mod was the cause! Got it fixed.

[nGAGE]

Ok... I didn't get a reply from my PM to "Teelk"... could please somebody else confirm that this would be the proper fix?

FILE: /includes/functions_categories_hierarchy.php

Original full line:

Code: Select all

 $s_group_names .= ( empty($s_group_names) ? '' : ', ' ) . sprintf("'%s'", str_replace("'", "'", $agcm_color->get_user_color($data['user_group_id'][$j], $data['group_name'][$j])));  

Original inline:

Code: Select all

 $agcm_color->get_user_color($data['user_group_id'][$j], $data['group_name'][$j])  

Proposed fix: I think there is something wrong with this part:

Code: Select all

 $agcm_color->get_user_color($data['group_id'][$j], 0, $data['group_name'][$j])  

My proposed fix: I think it should be this (and it has the same effect and works for me):

Code: Select all

 $agcm_color->get_user_color($data['group_id'][$j], $data['user_group_id'][$j], $data['group_name'][$j])  

[MWE_001]

My Issue with it is real simple. For some reason or the other, the only people whos names change colors anywhere on the board seems to be group owners and admin.

Ive messed with it, piched here, poked there, and yet still the smae results. If It wasnt such a major mod, I'd uninstall it completely. Teelk did a fine job with it, but needs overhauled something terrible.

[nGAGE]

I'm not totally sure, might be misunderstanding, but if I do understand it correctly, then there might actually not even be any bug anymore! Before I had the updating/resetting issue of the user's "user_group_id" to "0" all the time, I only excidentally found out about the UCP's UserColor Options.
Perhaps that's what makes you believe that the colors don't change, as you expect them to change by themselfs. However... that's not part of the mod (not entirely)... once a user has the choice of more then one color, the user will have to specify that color in his UCP himself (or the admins do it for them).
The reason is, if a user is member in 4 usergroups, that each allow the use of a special color, there is no way of telling which should get priority! Therefore the color will reset to default (in general that's the "Registered Users" color.

Follow this link for a quick visualization of what the users need to do! I actually made a very quick KnowledgeBase article for my members because they didn't realize it.

http://www.net-clan-gaming.com/kb.php?mode=article&k=1

Hope this is the solution/info you need... if not...

[MWE_001]

Nice.... I hadnt ever noticed the user part of it as well. BUT, When a user has logged in, and if the inactive user is set to display and session is enabled on the board, even members that are NOT logged in turn that color as well....

Once I figure that one out I should be ok.

[shentrax]

I only got colors on the group legend, the user online in x housr are only grey and white. The usernames on the forum indexes are gray. If you look at a post, it shows the default colors.

Dark Templates

reinstalled the mod 3+ times... cant figure it out.

http://nsbadclan.shentrax.net/forums

[shentrax]

added the adjustmnent from nGAGE, now SOME of the groups are colorizing.

Seems that the 'default' integra board group colors are taking presidence over the 'agc' colors....

e.g. the administrators and register users default colors are orange and white... Some members updated and have populated throughout the board with the correct colors.

any ideas?

[shentrax]

zomg. I'm retarded.

Profile -> Profile Settings -> Username Color Options...

<img>

[nGAGE]

Nice that you got it sorted shentrax. It's a lot of reading here and can get quite confusing, I'm sure. This whole mod (don't know why) got me thinking even now that it seems to work for me.

Why would the mod offer the "move up / move down" arrows in the ACP, if the order doesn't seem to have effect on what is default to a user anyhow?!
Now I'm not sure if it was intended to work the way I'll suggest in a moment, but I'm gonna add it to a list of my "TO-DOs".

It would be a lot better if the mod, when a user is added to a group, automatically applies the "highest ranked color" specified in the ACP's order of ranking of the colors, so it not only defines the order in the "Legend", but also by default picks a user color based on the highest positioned group. This will definitely stop people from thinking it's not working and prevent a lot of questions from the users, I'd say.

Perhaps the code is already in place to work like that, but there's a little typo somewhere, but if not... I'll see if I can add that tiny bit of extra code to automatically update the user's default color, based on the group's color ranking.

Hope I explained it correctly and hope I'll be able to come up with a proper update on this for those that are interested <img>

[krencho]

hello

can i get any help integrating agcm to shoutbox mod,
and someone can get out the sql queries from the install.php