Translate
Sub Menu
Links Menu
Online Users

In total there are 82 users online :: 2 registered, 0 hidden and 80 guests

Most users ever online was 561 on Fri Mar 20, 2020 1:13 am

Registered users: Bing [Bot], Google [Bot] based on users active over the past 60 minutes

Last Online
In order to view the online list you have to be registered and logged in.



We are a free and open
community, all are welcome.

Click here to Register

[BUG] Tell a friend

Moderator: Integra Moderator

[BUG] Tell a friend

PostAuthor: Max Paint » Tue Jul 31, 2007 2:06 pm

Your phpBB Version: 2.0.
phpBB Type: Integramod 141
MODs: No
Your knowledge: Advanced Knowledge
Board URL: http://www.maxpaint.de

PHP Version:
MySQL Version:


What was done before the problem appeared?
Nothing


What was done to try to solve the problem?
Nothing



De.scription and Message

The "tell a friend" button in portal is noch working correctly. This is since IM1.4.0. It chooses an incorrect Topic-Number for email (View printer friendly version) is working with correct topicnumber.
Last edited by Max Paint on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.

Max Paint
Members
Members
 
Posts: 31
Joined: Tue May 09, 2006 9:50 am

Re: [BUG] Tell a friend

PostAuthor: tmotley » Tue Jul 31, 2007 4:22 pm

Interestingly enough, the last news item to display on the portal page seems to be correct though... because ALL 'tellafriend' links match the last news item.

It's like it gets the link once and then doesn't fetch a new topic_id for subsequent articles.
Last edited by tmotley on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.
User avatar
tmotley
IntegraMODerators
IntegraMODerators
 
Posts: 524
Joined: Mon Mar 27, 2006 3:56 am
Location: Missouri, USA

Re: [BUG] Tell a friend

PostAuthor: tmotley » Tue Jul 31, 2007 4:45 pm

The following procedure does make the tellafriend seem to work correctly but I'd [size=99px]    {articles.BODY}</div><br><div>{articles.READ_MORE_LINK} <a><img></a> <a><img></a>  [/code]

INLINE FIND
Code: Select all
{TELL_LINK}


REPLACE WITH
Code: Select all
{INDEX_FILE}?topic_id={articles.ID}


Refresh portal and it should add on the the correct link=url to the tellafriend button.
Last edited by tmotley on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.
User avatar
tmotley
IntegraMODerators
IntegraMODerators
 
Posts: 524
Joined: Mon Mar 27, 2006 3:56 am
Location: Missouri, USA

PostAuthor: Max Paint » Wed Aug 08, 2007 8:11 am

No solution?
Last edited by Max Paint on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.

Max Paint
Members
Members
 
Posts: 31
Joined: Tue May 09, 2006 9:50 am

PostAuthor: tmotley » Wed Aug 08, 2007 10:14 am

My method sure seemed to work...
Last edited by tmotley on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.
User avatar
tmotley
IntegraMODerators
IntegraMODerators
 
Posts: 524
Joined: Mon Mar 27, 2006 3:56 am
Location: Missouri, USA

PostAuthor: Whisky » Thu Aug 09, 2007 7:46 am

"Max Paint";p="27857" wrote:No solution?


lol <img>
Last edited by Whisky on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.
I am the Lizard King, I can do anything

Whisky
Sr Integra Member
Sr Integra Member
 
Posts: 256
Joined: Thu May 18, 2006 2:28 am
Location: Brussels

PostAuthor: Max Paint » Thu Aug 09, 2007 8:51 am

I think it would be a good think to remove the bug and get the function work and not to simply replace it...
Last edited by Max Paint on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.

Max Paint
Members
Members
 
Posts: 31
Joined: Tue May 09, 2006 9:50 am

PostAuthor: Max Paint » Sat Aug 18, 2007 2:45 am

*bump*
Last edited by Max Paint on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.

Max Paint
Members
Members
 
Posts: 31
Joined: Tue May 09, 2006 9:50 am

PostAuthor: Helter » Sat Aug 18, 2007 10:31 am

"Max Paint";p="28024" wrote:*bump*

im not sure why your choosing to ignore the posted fix. Ive just spen an hour trying to fix the TELL_LINK url to no avail. Here is the code if you wish to try yourself

Code: Select all
            "TELL_LINK" => append_sid("http].$HTTP_SERVER_VARS['PHP_SELF']."?topic_id=" . $article['topic_id'], true),  


ive added tmotley's fix to the Integra2 template on this site and if I dont find any problems with it, I will add it to the IM140 dl
Last edited by Helter on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.
Image
Please do not PM for support
User avatar
Helter
Administrator
Administrator
 
Posts: 4126
Joined: Sat Mar 11, 2006 4:46 pm
Location: Seattle Wa

PostAuthor: Max Paint » Sun Aug 19, 2007 1:58 am

my "problem" is that fixing the template does not fix the function and ONE advantage of phpBB is that skins and functions are different things.
I could also replace all languagefiles and write all words into the tpl-docs. That "works", too.
If we do it like "tmotley" we don't fix the function and when another skin is uploaded, the error is there again. Why? Cause the bug wasn't fixed, just "hidden".

BUt thanks for help...
Last edited by Max Paint on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.

Max Paint
Members
Members
 
Posts: 31
Joined: Tue May 09, 2006 9:50 am

Re: [BUG] Tell a friend

PostAuthor: Helter » Sun Aug 19, 2007 2:55 pm

this is not a "skin" fix. It is a block fix. Almost all blocks are identical from template, to template. This just means that you need to update the news block for every template.
Last edited by Helter on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.
Image
Please do not PM for support
User avatar
Helter
Administrator
Administrator
 
Posts: 4126
Joined: Sat Mar 11, 2006 4:46 pm
Location: Seattle Wa

PostAuthor: richiebgood » Sun Aug 19, 2007 4:01 pm

i only noticed this now my self. I am getting a cracker tracker error when i try to 'tell a friend' about the first news post on the portal. The others are all fine.

The printer friendly version works on all the articles, just the tell a friend is messed.


The solution in the acp log manager does nothing and i tried the above fix, but still errors.


edit ---- It is something to do with the actualy post. I made another new post to test and that works fine now. So i am trying to see what makes it different from the other posts, maybe the poll is doing it.


edit-- ya it is the polls that are doing the damage. Any suggestions?
Last edited by richiebgood on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.

richiebgood
Sr Integra Member
Sr Integra Member
 
Posts: 329
Joined: Tue Aug 08, 2006 1:01 am
Location: Ireland

PostAuthor: Max Paint » Sun Aug 19, 2007 9:53 pm

The problem is caused by the following fact (I think)

Tell_link is not includet into BlockVariables as are the other functions for the news block (printer, read full).

setVariables: Tell_Link

and then setBlockVariables.

Therefore $article doesn't work correctly.
Last edited by Max Paint on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.

Max Paint
Members
Members
 
Posts: 31
Joined: Tue May 09, 2006 9:50 am

PostAuthor: richiebgood » Mon Aug 20, 2007 9:08 am

which problem, the orginal posted problem or my problem where only news posts with polls give problems?
Last edited by richiebgood on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.

richiebgood
Sr Integra Member
Sr Integra Member
 
Posts: 329
Joined: Tue Aug 08, 2006 1:01 am
Location: Ireland

PostAuthor: Max Paint » Mon Aug 20, 2007 10:08 am

the "original" problem
Last edited by Max Paint on Wed Dec 31, 1969 5:00 pm, edited 1 time in total.

Max Paint
Members
Members
 
Posts: 31
Joined: Tue May 09, 2006 9:50 am

Next

Return to Confirmed Bugs

Who is online

Registered users: Bing [Bot], Google [Bot]